Fixes #38867: Clear browser data on logout#10741
Open
ehelms wants to merge 1 commit intotheforeman:developfrom
Open
Fixes #38867: Clear browser data on logout#10741ehelms wants to merge 1 commit intotheforeman:developfrom
ehelms wants to merge 1 commit intotheforeman:developfrom
Conversation
5bb57b2 to
4c0e52e
Compare
jeremylenz
reviewed
Oct 28, 2025
chris1984
reviewed
Oct 31, 2025
Member
chris1984
left a comment
There was a problem hiding this comment.
Would this just clear the cache for Foreman or everything in the browser?
Member
Author
Just the data for the Foreman site itself.
How do you we ensure a clean line is draw between what we save and what we do not? I get the niceness form a user perspective, but I feel like this should be handled persistently in the database if we really want to offer users this. |
Signed-off-by: Eric D. Helms <ericdhelms@gmail.com>
4c0e52e to
dc9babb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on the implementation described here: https://github.com/github/secure_headers/blob/main/docs/per_action_configuration.md#clearing-browser-cache