Skip to content

Fix incorrect instruction for kubevirt #4569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maximiliankolb merged 1 commit into from
Jan 8, 2026
Merged

Fix incorrect instruction for kubevirt #4569

maximiliankolb merged 1 commit into from
Jan 8, 2026
+1 −1

Conversation

@arvind4501
Copy link
Contributor

@arvind4501 arvind4501 commented Jan 7, 2026 •
edited
Loading

What changes are you introducing?

https://docs.theforeman.org/3.16/Provisioning_Hosts/index-foreman-el.html says:-

In the Namespace field, enter the user name of the Kubernetes cluster. and thats incorrect we should use namspace instead user name

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • We do not accept PRs for Foreman older than 3.12.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Jan 7, 2026
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

The PR preview for cad63a6 is available at theforeman-foreman-documentation-preview-pr-4569.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@jafiala jafiala self-requested a review January 7, 2026 12:23
@jafiala jafiala added style review done No issues from docs style/grammar perspective and removed Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Not yet reviewed Needs testing Requires functional testing labels Jan 7, 2026
AkshayGadhaveRH
AkshayGadhaveRH approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@AkshayGadhaveRH AkshayGadhaveRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maximiliankolb maximiliankolb merged commit 4fa0239 into theforeman:master Jan 8, 2026
11 checks passed
maximiliankolb pushed a commit that referenced this pull request Jan 8, 2026
@arvind4501 @maximiliankolb
Fix instruction for kubevirt (#4569)
fc0d5f1 
Co-authored-by: Arvind Jangir <ajangir@ajangir-thinkpadt14gen5.punetw6.csb>
(cherry picked from commit 4fa0239)
maximiliankolb pushed a commit that referenced this pull request Jan 8, 2026
@arvind4501 @maximiliankolb
Fix instruction for kubevirt (#4569)
db93676 
Co-authored-by: Arvind Jangir <ajangir@ajangir-thinkpadt14gen5.punetw6.csb>
(cherry picked from commit 4fa0239)
maximiliankolb pushed a commit that referenced this pull request Jan 8, 2026
@arvind4501 @maximiliankolb
Fix instruction for kubevirt (#4569)
23cb0b2 
Co-authored-by: Arvind Jangir <ajangir@ajangir-thinkpadt14gen5.punetw6.csb>
(cherry picked from commit 4fa0239)
maximiliankolb pushed a commit that referenced this pull request Jan 8, 2026
@arvind4501 @maximiliankolb
Fix instruction for kubevirt (#4569)
458ce96 
Co-authored-by: Arvind Jangir <ajangir@ajangir-thinkpadt14gen5.punetw6.csb>
(cherry picked from commit 4fa0239)
maximiliankolb pushed a commit that referenced this pull request Jan 8, 2026
@arvind4501 @maximiliankolb
Fix instruction for kubevirt (#4569)
4494fee 
Co-authored-by: Arvind Jangir <ajangir@ajangir-thinkpadt14gen5.punetw6.csb>
(cherry picked from commit 4fa0239)
maximiliankolb pushed a commit that referenced this pull request Jan 8, 2026
@arvind4501 @maximiliankolb
Fix instruction for kubevirt (#4569)
8c64e94 
Co-authored-by: Arvind Jangir <ajangir@ajangir-thinkpadt14gen5.punetw6.csb>
(cherry picked from commit 4fa0239)
@maximiliankolb
Copy link
Contributor

maximiliankolb commented Jan 8, 2026

Merged to "master" and cherry-picked:
adf7d1e..fc0d5f1 3.17 -> 3.17
7d00f54..db93676 3.16 -> 3.16
560c4f9..23cb0b2 3.15 -> 3.15
a07f376..458ce96 3.14 -> 3.14
969cab7..4494fee 3.13 -> 3.13
f9a000f..8c64e94 3.12 -> 3.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evgeni evgeni evgeni approved these changes

@jafiala jafiala Awaiting requested review from jafiala

+1 more reviewer

@AkshayGadhaveRH AkshayGadhaveRH AkshayGadhaveRH approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

style review done No issues from docs style/grammar perspective

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arvind4501 @maximiliankolb @evgeni @AkshayGadhaveRH @jafiala