Add prerequisite to REX Pull Provider #4559
Open
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Satellite, REX is always enabled on Foreman Server and Smart Proxy Servers by default.
github-actions
bot
added
Needs tech review
maximiliankolb
changed the title
| For more information, see {InstallingServerDocURL}enabling-remote-execution[Enabling remote execution in _{InstallingServerDocTitle}_]. | ||
| endif::[] | ||
| ifeval::["{ProductName}" == "{SmartProxyServer}"] | ||
| For more information, see {InstallingSmartProxyDocURL}enabling-remote-execution[Enabling remote execution in _{InstallingSmartProxyDocTitle}_]. |
Member
There was a problem hiding this comment.
This looks like it could also be an xref to the module rather than a link.
| .Prerequisites | ||
| * Ensure that you have enabled remote execution on your {ProductName}. | ||
| ifeval::["{ProductName}" == "{ProjectServer}"] | ||
| For more information, see {InstallingServerDocURL}enabling-remote-execution[Enabling remote execution in _{InstallingServerDocTitle}_]. |
Member
There was a problem hiding this comment.
You're adding the module to the server installation guide's master.adoc only for foreman-el and foreman-deb, but you're adding this prerequisite for everything except satellite. This results in a broken link in the katello and orcharhino builds.
Member
There was a problem hiding this comment.
Similar to the one below, this should perhaps be an xref.
Contributor
They do by default. It's possible to disable it. |
aneta-petrova
added
style review done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
The third item is the result of a bug report.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Needs TECH ACK on the following assumptions which I could non conclusively verify in code:
Contributor checklists
Please cherry-pick my commits into: