-
Notifications
You must be signed in to change notification settings - Fork 108
Add modules to upload content to Deb repositories #4531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add modules to upload content to Deb repositories #4531
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds documentation modules describing how to upload Debian package content to Deb repositories via both the CLI and the web UI, and integrates them into the shared importing content guide. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@quba42 Can you please review my PR? |
| = Uploading content to Deb repositories by using Hammer CLI | ||
|
|
||
| [role="_abstract"] | ||
| You can upload individual Deb packages to Deb repositories by using Hammer CLI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional (because we're not there with the other abstracts yet and it wouldn't be fair to require this at the moment): Ideally, an abstract should also clarify the use case: when and why a user might want to follow the procedure, not just what the procedure does.
For example when: Is the "individual packages" part important here? Is this what distinguishes this procedure from other procedures in the guide? When would a user want to upload an individual package?
Or why: What will happen when the package will be uploaded? Can we explicitly specify that the package will then be available for hosts?
|
@quba42 Can you please review my PR? |
|
We have a pretty strong "best practice recommendation" that users don't mix uploaded and synced deb content in a single Katello repository. In the GUI we have a soft enforcement of this preference: If a repo has an "Upstream URL" set (configured for syncing), then the upload box contains the following message (won't let you upload): You can work around this by removing and re-adding the Upstream URL, and we don't have any such enforcement for Hammer CLI uploads. We did once discuss making enforcement stricter, but never got around to actually implementing that. My point is: Currently these new upload docs don't mention any of this at all, and I think they should? Otherwise we are encouraging users to start using the feature in a way that we don't want them to use it. We may also want to meet up to discuss the background in more detail? |
What changes are you introducing?
Add two modules to upload Deb packages to Deb repositories.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
We have prodedures to RPM packages but not Deb packages.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Tested on Foreman 3.16+Katello 4.18.
Contributor checklists
Please cherry-pick my commits into:
Summary by Sourcery
Document uploading content to Deb repositories via both CLI and web UI.
Documentation: