Feature/add unique users counter#11
Open
ptjuanramos wants to merge 3 commits intothe-urlist:masterfrom
Open
Conversation
… to HashedIp hashset. If the ip didn't already exist, increment the property UniqueViews that is going to be persisted as a document.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal description
Simple way of getting the unique views of a link bundle.
After a request is made to GetLinks endpoint, the new implemention gets the user IP address and in order to safely store the IP address in the new collection property, the IP goes through a RFC 2898 hash function, which uses the
LinkBundleid as his salt.If the user IP wasn't added before, the new implementon increments the number of unique views, described by the new
uniqueViewsproperty.{ "id": "ee5af123-4384-46bb-a837-54eef2158828", "userId": "", "vanityUrl": "postman-test", "description": "", "links": [ ], + "uniqueViews": 1, + "hashedIps": [ + "CugZGyXRtR5Th5BOHCg0NkLyIQxqK+cs" + ] }