Consensus Under Deadline #8

rafasu4 · 2023-01-25T14:02:05Z

No description provided.

rafasu4 · 2023-01-25T14:03:16Z

Consensus Under Deadline algorithm in pure python, followed by the following article: https://arxiv.org/abs/1905.07173

rafasu4 · 2023-01-31T08:50:29Z

@the-maldridge hi Michael!
I would really appreciate for your notes on the PR, as I'm invested in it and would love to contribute. Further more, this is part of my class grade, so it would really help me if you could take a time for reviewing this PR :)
Thanks!

the-maldridge · 2023-01-31T09:24:09Z

I appreciate the deadlines you are under, but be aware that the open source world moves on a timeline completely divorced from that of academia. I will get to this PR as I have time. Please do not close it and open a new one, git has mechanisms for pushing state changes when conflicts exist.

erelsgl · 2023-02-02T06:28:47Z

py3votecore/consensus_under_deadline.py

@@ -0,0 +1,394 @@
+import doctest


The file should start with a title containing the article name and link, author names, programmer name, and date.

This doesn't match the style of any of the other files. I will accept a header linking the arxiv papger, but the other information is to be dropped. You may add relevant names to the contributors file at the root of the repo.

erelsgl · 2023-02-02T06:28:54Z

test_functionality/test_consensus_under_deadline.py

@@ -0,0 +1,127 @@
+from py3votecore.consensus_under_deadline import ConsensusUnderDeadline, mdvr


The file should start with a title containing the article name and link, author names, programmer name, and date.

As with the other file, no it shouldn't. This should match the style of other files in the repo (i.e. GPL header), or I will accpet a very short header that includes the link to the Arxiv reference document.

erelsgl · 2023-02-02T06:29:55Z

py3votecore/consensus_under_deadline.py

+from collections import Counter
+
+
+logging.basicConfig(level=logging.DEBUG)


Global logging configuration should not be set in a unit - only in the main program

py3votecore/consensus_under_deadline.py

the-maldridge

Lots of small issues. Also you will eventually need to perform a rebase and squash to make your PR one functional change without all the intermediate steps. See individual comments for each item.

the-maldridge · 2023-02-08T03:42:45Z

py3votecore/consensus_under_deadline.py

@@ -0,0 +1,394 @@
+import doctest


This doesn't match the style of any of the other files. I will accept a header linking the arxiv papger, but the other information is to be dropped. You may add relevant names to the contributors file at the root of the repo.

the-maldridge · 2023-02-08T03:43:23Z

py3votecore/consensus_under_deadline.py

+        Returns:
+            The winner alternative
+
+        ---------------------------------TESTS---------------------------------


As near as I can tell the mdvr function is dead code that exists solely to make these tests work. If you want to write an example, it should go into the class docstring. If you want to write an integration test, it should go into an integration test that's part of a different component.

the-maldridge · 2023-02-08T03:43:44Z

py3votecore/consensus_under_deadline.py

+        The model was presented by Marina Bannikova, Lihi Dery, Svetlana Obraztsova, Zinovi Rabinovich, Jeffrey S. Rosenschein (2019),
+        https://arxiv.org/abs/1905.07173
+
+        Author: Raphael Suliman


Migrate authorship information to the CONTRIBUTORS file at the root of the repo.

the-maldridge · 2023-02-08T03:44:30Z

py3votecore/consensus_under_deadline.py

+
+class ConsensusUnderDeadline():
+    '''
+        A class representing a model for group decision making under strict deadline, based on iterative process. Each alternative must be accept


line wrapping here looks funky. You probably need to reflow this block comment to bring it into the expected line width I see you have used elsewhere in the file.

the-maldridge · 2023-02-08T03:48:33Z

py3votecore/consensus_under_deadline.py

+                remaining_rounds - a threshold for the amount if rounds left until decision should be taken
+                random_selection - whether the selection of voter for changing their ballot. If False - the smallest voter's number will be selected
+        '''
+        logger.info('ConsensusUnderDeadline object created')


This should be at debug, possibly even trace priority, definitely not info.

the-maldridge · 2023-02-08T03:52:25Z

py3votecore/consensus_under_deadline.py

+            >>> print(cud.deploy_algorithm())
+            null
+        '''
+        logger.info('deploying algorithm')


again, debug priority at most, this log line probably shouldn't even happen.

the-maldridge · 2023-02-08T03:53:48Z

py3votecore/consensus_under_deadline.py

+        '''
+            Lower round by one - symbolize a passing iteration.
+
+            ---------------------------------TESTS---------------------------------


Why is this in a block comment? This shouldn't be here.

the-maldridge · 2023-02-08T03:55:26Z

py3votecore/consensus_under_deadline.py

+            Returns:
+                List of alternatives with a chance to win
+
+            ---------------------------------TESTS---------------------------------


This really looks like you're embedding what should have been automated integration tests into the docstrings. doctests is meant to ensure that your examples work, not to serve as your general purpose test framework.

the-maldridge · 2023-02-08T03:57:19Z

test_functionality/test_consensus_under_deadline.py

@@ -0,0 +1,127 @@
+from py3votecore.consensus_under_deadline import ConsensusUnderDeadline, mdvr


As with the other file, no it shouldn't. This should match the style of other files in the repo (i.e. GPL header), or I will accpet a very short header that includes the link to the Arxiv reference document.

the-maldridge · 2023-02-08T03:58:10Z

test_functionality/test_consensus_under_deadline.py

+        self.assertEqual(mdvr(voters=v, voters_type = v_type, alternatives=alters, default_alternative=df_alter,voters_preferences=[['a', 'b', 'c', 'd'], ['a', 'c', 'b', 'd'], ['a', 'c', 'b', 'd'], ['a', 'b', 'c', 'd'], ['a', 'b', 'd', 'c']], remaining_rounds=t, random_selection=False), 'a') # test case with unanimously on the start
+
+if __name__ == '__main__':
+    unittest.main()


Missing final newline. This is usually a configuration problem with your editor.

the-maldridge · 2023-02-08T04:02:57Z

Also note that at this time I have not yet reviewed the conformance of the implemented algorithm against the workflow discussed in the linked reference material. I made a first pass review of the code, and I will make an additional review pass for the actual results of the algorithm.

stycks4 and others added 21 commits December 4, 2022 13:11

🥳init

3e59672

📝headers for algorithm class

72b8de6

📝headers description

e2f2cbd

♻️structure + docs

923a8fb

♻️empty implementation

74b2a22

✅unitests

4b4c453

✅unittest added

be780f8

✅possib;e_winners

d173c64

✅change vote

e74eb73

✅votes_calculate_results

50d4870

s

18be337

✅subfunctions implementation

8b9d937

🔊logs added for subfunctions

c0de3ac

✅full algorithm implemented

c34b6b6

♻️create outer function for CUD

5406473

🥅error handles

9b8515b

♻️restructure

0c60e72

♻️restructure

1674dcc

✅running time for algorithm

5188eba

⚡improvement for edge case

7817d0a

♻️restructure hierarchy

89b79f5

erelsgl suggested changes Feb 2, 2023

View reviewed changes

✏️intro for the algorithm

3a76f9c

the-maldridge requested changes Feb 8, 2023

View reviewed changes

the-maldridge changed the title ~~Structure changes~~ Consensus Under Deadline Feb 8, 2023

		@@ -0,0 +1,127 @@
		from py3votecore.consensus_under_deadline import ConsensusUnderDeadline, mdvr

		from collections import Counter


		logging.basicConfig(level=logging.DEBUG)

Consensus Under Deadline #8

Are you sure you want to change the base?

Consensus Under Deadline #8

Uh oh!

Conversation

rafasu4 commented Jan 25, 2023

Uh oh!

rafasu4 commented Jan 25, 2023

Uh oh!

rafasu4 commented Jan 31, 2023

Uh oh!

the-maldridge commented Jan 31, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

the-maldridge left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

the-maldridge commented Feb 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants