[TH2-4937] add api compatibility compliance check in workflows#245
[TH2-4937] add api compatibility compliance check in workflows#245ghost wants to merge 1 commit intodev-version-5from
Conversation
OptimumCode
left a comment
OptimumCode
left a comment
There was a problem hiding this comment.
I am not sure but I think for release workflows the build job should depend on the result of the compatibility check.
Also, as I can see we already have some errors for compatibility check. Probably, some of those errors should be ignored (because it is not a public API). We need to check if we can configure the verification to ignore those classes
| targetJarUrl: https://s01.oss.sonatype.org/content/repositories/releases/com/exactpro/th2/cradle-core/5.0.2-dev/cradle-core-5.0.2-dev.jar | ||
| api-compatibility-check-cassandra: | ||
| uses: th2-net/.github/.github/workflows/japi-compliance-checker.yml@main | ||
| with: | ||
| projectPath: ./cradle-cassandra | ||
| continueOnError: true | ||
| targetJarUrl: https://s01.oss.sonatype.org/content/repositories/releases/com/exactpro/th2/cradle-cassandra/5.0.2-dev/cradle-cassandra-5.0.2-dev.jar |
There was a problem hiding this comment.
I think we should use the latest non-dev release here
There was a problem hiding this comment.
We need to check if we can configure the verification to ignore those classes -> we can just remove cradle-cassandra check from workflow and only check cradle core API. I included both of them just to show how it works.
There was a problem hiding this comment.
If we use latest non-dev release we probably will have issues in public API, as I remember we did have some breaking changes. That's why I decided to use lates compatible version, so we can control compatibility starting from it
1 participant
No description provided.