-
Notifications
You must be signed in to change notification settings - Fork 11
docs: fix absolute /docs links in Android (Termux) guide #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @LbsLightX, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue with internal documentation links in the Android (Termux) guide. The changes ensure that all links conform to the absolute path requirement of VitePress routing, thereby improving the navigability and correctness of the documentation for users following the guide. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates most of the internal documentation links in the Android (Termux) guide to be absolute paths, which is great for routing consistency in VitePress. However, I noticed one link where the update seems to have been applied incorrectly, adding a slash to the link text instead of the URL path. I've left a suggestion to correct this. Otherwise, the changes look good.
docs/guides/teldrive-on-android.md
Outdated
| ### Basic `config.toml` (Recommended for New Users) | ||
|
|
||
| 1. First, read the [usage documentation](docs/getting-started/usage) for configuring a Supabase database. | ||
| 1. First, read the [/usage documentation](docs/getting-started/usage) for configuring a Supabase database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the forward slash was accidentally added to the link text instead of the URL path, and the path itself wasn't made absolute. To make this an absolute link consistent with the other changes, the path should start with /docs/....
| 1. First, read the [/usage documentation](docs/getting-started/usage) for configuring a Supabase database. | |
| 1. First, read the [usage documentation](/docs/getting-started/usage) for configuring a Supabase database. |
|
Reopening sorry about that |
Fix internal documentation links to use absolute
/docs/...paths as required by VitePress routing.