Skip to content

Handle cross-space PageLink #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seonglae merged 3 commits into from
Feb 4, 2026
Merged

Handle cross-space PageLink #291

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea5ba4c
chore: reformat context
seonglae Dec 15, 2025
e402c83
Merge branch 'main' into feature/modify-link-to-redirect-to-notion.so…
seonglae Dec 20, 2025
aeb5bc2
Merge branch 'main' into feature/modify-link-to-redirect-to-notion.so…
seonglae Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions packages/nreact/src/context.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react'

import { defaultMapImageUrl, defaultMapPageUrl } from '@texonom/nutils'
import { defaultMapImageUrl, defaultMapPageUrl, parsePageId } from '@texonom/nutils'

import { AssetWrapper } from './components/asset-wrapper'
import { Checkbox as DefaultCheckbox } from './components/checkbox'
Expand Down Expand Up @@ -75,7 +75,22 @@ export interface PartialNotionContext {

const DefaultLink: React.FC = props => <a target='_blank' rel='noopener noreferrer' {...props} />
const DefaultLinkMemo = React.memo(DefaultLink)
const DefaultPageLink: React.FC = props => <a {...props} />
const DefaultPageLink: React.FC<React.AnchorHTMLAttributes<HTMLAnchorElement>> = ({ href, ...props }) => {
const { recordMap, rootSpaceId } = useNotionContext()
let finalHref = href as string | undefined

if (typeof href === 'string' && rootSpaceId) {
const pageId = parsePageId(href)

if (pageId) {
const block = recordMap?.block?.[pageId]?.value

if (!block || block.space_id !== rootSpaceId) finalHref = `https://notion.so/${pageId.replace(/-/g, '')}`
}
}

return <a href={finalHref} {...props} />
}
const DefaultPageLinkMemo = React.memo(DefaultPageLink)

const DefaultEmbed = props => <AssetWrapper {...props} />
Expand Down
Loading