feat: allow add types when we use FormState type#475
Open
mau2099 wants to merge 1 commit intoteslamotors:masterfrom
Open
feat: allow add types when we use FormState type#475mau2099 wants to merge 1 commit intoteslamotors:masterfrom
mau2099 wants to merge 1 commit intoteslamotors:masterfrom
Conversation
80aa6f3 to
3c561c7
Compare
Author
|
maintainer is requiring at least 3 thumbs up here from senior typescript devs, so if you are seeing this, drop your thoughts! |
|
I believe this is great for having strictly typed form schema. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so that way, we can do:
but we can still use former way, so no breaking changes
*Note: changes based on this chart https://teslamotors.github.io/informed/api-reference/fieldState