Allow for false and zero field values to be re-initialized correctly#421
Open
juancstlm wants to merge 1 commit intoteslamotors:masterfrom
Open
Allow for false and zero field values to be re-initialized correctly#421juancstlm wants to merge 1 commit intoteslamotors:masterfrom
juancstlm wants to merge 1 commit intoteslamotors:masterfrom
Conversation
| // Otherwise use the fields initial value | ||
| if ( | ||
| !this.getValue(name) && | ||
| (this.getValue(name) == null || this.getValue(name) == undefined) && |
Contributor
There was a problem hiding this comment.
no need for the OR clause as undefined already equals null
Collaborator
There was a problem hiding this comment.
Agreed please make that change
joepuzzo
approved these changes
Sep 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow for falsy values such as
falseand0to be re-initialized properly without reverting back to the initial value if they arefalseor0