Add UTC timezone to dates fetched from the database.#12
Merged
Conversation
When we store the created_at objects in the database, they're stored as timestamp automatically. Unfortunately, they're restored without any timezone information, making them invalid strings to parse as RCF3339. I'm creating a custom type that can handle those cases when we read the data. Preserving the format when we serialize it to other clients. The dates are always UTC, so we don't need to worry about other timezone offsets except +00:00, or Z as a shortcut.
diptanu
approved these changes
Jan 3, 2026
calavera
force-pushed
the
optional_date_without_timezone
branch
from
dd9de4d to
e286683
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we store the created_at objects in the database, they're stored as timestamp automatically. Unfortunately, they're restored without any timezone information, making them invalid strings to parse as RCF3339.
I'm creating a custom type that can handle those cases when we read the data. Preserving the format when we serialize it to other clients.
The dates are always UTC, so we don't need to worry about other timezone offsets except +00:00, or Z as a shortcut.