Skip to content

refactor(router): minor improvements to exception page #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
innocenzi merged 1 commit into from
Jan 20, 2026
Merged

refactor(router): minor improvements to exception page #1907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 27 additions & 27 deletions packages/router/src/Exceptions/local/bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

74 changes: 37 additions & 37 deletions packages/router/src/Exceptions/local/dist/main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/router/src/Exceptions/local/dist/style.css
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 5 additions & 6 deletions packages/router/src/Exceptions/local/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,24 +8,23 @@
},
"devDependencies": {
"@nuxt/ui": "^4.3.0",
"@shikijs/langs-precompiled": "^3.20.0",
"@shikijs/langs-precompiled": "^3.21.0",
"@tailwindcss/vite": "^4.1.18",
"@vitejs/plugin-vue": "^6.0.3",
"@vue/tsconfig": "^0.8.1",
"@vueuse/components": "^14.1.0",
"@vueuse/core": "^14.1.0",
"arktype": "^2.1.29",
"motion-v": "^1.7.4",
"shiki": "^3.20.0",
"sql-formatter": "^15.6.12",
"shiki": "^3.21.0",
"sql-formatter": "^15.7.0",
"tailwindcss": "^4.1.18",
"temporal-polyfill": "^0.3.0",
"typescript": "~5.9.3",
"vite": "8.0.0-beta.2",
"vite-plugin-singlefile": "^2.3.0",
"vue": "^3.5.26",
"vue": "^3.5.27",
"vue-router": "^4.6.4",
"vue-tsc": "^3.2.1"
"vue-tsc": "^3.2.2"
},
"trustedDependencies": [
"@tailwindcss/oxide"
Expand Down
16 changes: 12 additions & 4 deletions packages/router/src/Exceptions/local/src/components/stacktrace/application-frame.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,17 @@ const $props = defineProps<{
</script>

<template>
<u-collapsible class="border border-default rounded-md overflow-hidden" default-open>
<u-collapsible
class="border border-default rounded-md overflow-hidden"
default-open
:disabled="!frame.snippet"
>
<!-- Folder header -->
<template v-slot="{ open }">
<div class="flex items-center gap-x-2 bg-accented/60 data-[state=open]:bg-accented/80 hover:bg-accented/80 px-4 py-3 text-dimmed text-sm transition-colors cursor-pointer">
<div
class="flex items-center gap-x-2 bg-accented/60 data-[state=open]:bg-accented/80 hover:bg-accented/80 px-4 py-3 text-dimmed text-sm transition-colors"
:class="{ 'cursor-pointer': frame.snippet }"
>
<!-- Open indicator -->
<div class="mr-1 shrink-0">
<div
Expand All @@ -26,6 +33,7 @@ const $props = defineProps<{
<symbol-call :frame class="grow" />
<!-- File -->
<file-label
v-if="frame.absoluteFile"
class="min-w-[20%] text-right shrink-0"
:relative-file="frame.relativeFile"
:absolute-file="frame.absoluteFile"
Expand All @@ -36,8 +44,8 @@ const $props = defineProps<{
</template>
<!-- Folder content -->
<template v-slot:content>
<div class="bg-muted py-1 border-default border-t">
<code-snippet v-if="frame.snippet" :snippet="frame.snippet" :file="frame.absoluteFile" />
<div class="bg-muted py-1 border-default border-t" v-if="frame.snippet">
<code-snippet :snippet="frame.snippet" :file="frame.absoluteFile" />
</div>
</template>
</u-collapsible>
Expand Down
Loading