feat(console): add ability to prevent built-in console commands from loading #1906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
ConsoleApplication::bootandConsoleConfigto add options to prevent the built-in console commands from being loaded, which is useful in a context where we are building an external CLI application on top oftemnpest/console.The loading prevention is done through
DiscoveryLocation, which already had support for detecting if the class came from Tempest directly (by checking the namespace).The console command discovery uses the new option in
ConsoleConfigand this heuristic to determine whether to load a specific command.This may cause issues if we ever build an external but first-party console application which namespace starts with
Tempest, so we might need to update how this work later. However, for now I think it is good enough.