Magic link #436
Magic link #436
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (7)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
| hash = result.hash; | ||
| expires = result.expires; | ||
| sentTo = email; | ||
| } else if (whatsapp) { |
There was a problem hiding this comment.
@apurvaubade we wont need this code here now. Please remove
| } | ||
|
|
||
| // Determine identifier type | ||
| let identifierType = 'username'; |
There was a problem hiding this comment.
@apurvaubade here we are assuming that the user will either pass the username or mobile right? We can also ask him to pass the username. why this is hardcoded?
| const magicLink = this.magicLinkRepository.create({ | ||
| token, | ||
| identifier: requestDto.identifier, | ||
| identifier_type: identifierType, |
There was a problem hiding this comment.
@apurvaubade why are we storing identifier type?
| } | ||
| } | ||
|
|
||
| async cleanupExpiredLinks(): Promise<void> { |
2 participants
No description provided.