Step __init__ shall accept list of raw step data
#4523
+37
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This particular normalization happened inside the method, which opened its `_raw_data` and `data` operations to way more types than necessary. `Step.__init__` now accepts `list[_RawStepData]` and nothing else. Plus, the parameter name is now `raw_data` rather than `data` as `data` labels data classes and their instances rather than raw, unnormalized input.
happz
added
code | style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This particular normalization happened inside the method, which opened its
_raw_dataanddataoperations to way more types than necessary.Step.__init__now acceptslist[_RawStepData]and nothing else. Plus, the parameter name is nowraw_datarather thandataasdatalabels data classes and their instances rather than raw, unnormalized input.Pull Request Checklist