Skip to content

Added Integration Tests for File provider #4510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vaibhavdaren wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added Integration Tests for File provider #4510

vaibhavdaren wants to merge 1 commit into from
+107 −2

Conversation

@vaibhavdaren
Copy link
Contributor

@vaibhavdaren vaibhavdaren commented Jan 19, 2026 •
edited
Loading

Pull Request Checklist

  • implement the feature
  • Fix for single RPM file

@vaibhavdaren vaibhavdaren changed the title Added Intgeration Tests for File provider Added Integration Tests for File provider Jan 19, 2026
@happz happz force-pushed the vaibhav-artifact-install-integration-tests branch from b8f1dbe to f6ca434 Compare January 20, 2026 13:29
@vaibhavdaren vaibhavdaren force-pushed the vaibhav-intx-file-provider branch from 5e1ce42 to 2b3099a Compare January 20, 2026 14:34
@happz happz force-pushed the vaibhav-artifact-install-integration-tests branch from f6ca434 to 3a9909b Compare January 20, 2026 14:35
@vaibhavdaren vaibhavdaren force-pushed the vaibhav-intx-file-provider branch from 2b3099a to a64b81f Compare January 20, 2026 14:37
@vaibhavdaren vaibhavdaren self-assigned this Jan 20, 2026
@vaibhavdaren vaibhavdaren added this to the 1.66 milestone Jan 20, 2026
@github-project-automation github-project-automation bot moved this to backlog in planning Jan 20, 2026
@vaibhavdaren vaibhavdaren moved this from backlog to review in planning Jan 20, 2026
@vaibhavdaren vaibhavdaren added plugin | artifact Related to the `prepare/artifact` plugin. code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. labels Jan 20, 2026
@vaibhavdaren
Copy link
Contributor Author

vaibhavdaren commented Jan 20, 2026

Note: To be merged only after : #4449

@vaibhavdaren vaibhavdaren added code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. and removed code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. labels Jan 20, 2026
vaibhavdaren
vaibhavdaren commented Jan 20, 2026
View reviewed changes
tmt/steps/prepare/artifact/providers/file.py
),
silent=True,
)
else: # Local file, push it to the guest
Copy link
Contributor Author

@vaibhavdaren vaibhavdaren Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: A good example how writing integration tests helped us find an issue at an early stage.

@vaibhavdaren vaibhavdaren marked this pull request as ready for review January 20, 2026 18:26
@vaibhavdaren vaibhavdaren mentioned this pull request Jan 20, 2026
Open
7 tasks
@happz happz added the status | blocked The merging of PR is blocked on some other issue label Jan 20, 2026
Base automatically changed from vaibhav-artifact-install-integration-tests to main January 20, 2026 20:42
@vaibhavdaren vaibhavdaren force-pushed the vaibhav-intx-file-provider branch from a64b81f to d41630e Compare January 20, 2026 23:33
@vaibhavdaren vaibhavdaren added step | prepare Stuff related to the prepare step test coverage Improvements or additions to test coverage of tmt itself and removed status | blocked The merging of PR is blocked on some other issue labels Jan 21, 2026
@happz happz removed this from the 1.66 milestone Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vaibhavdaren vaibhavdaren

Labels

code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. plugin | artifact Related to the `prepare/artifact` plugin. step | prepare Stuff related to the prepare step test coverage Improvements or additions to test coverage of tmt itself

Projects

planning
Status: review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vaibhavdaren @happz