Skip to content

Conversation

@LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Jan 16, 2026

The original code should already have allowed for libraries with different name part but same repo, but as shown in practice that did not happen. This is because the string construction in of str(Beakerlib) only took the last part of the name, disallowing /foo/common, /bar/common. But beakerlib does not seem to actually have that restriction afaict.

Summary of changes:

  • Reworked how the library's repo are cloned allowing for a big degree of collision
  • Allow for whole libraries to collide and take the first definition Postponed
  • Adjust the order of library fetching to account for the relaxed condition above Postponed
  • Moved the non-existing-url handling to the git_clone utility
  • Adjusted the display of the beakerlib library to display the full (repo)/(name) as it would be used in rlImport

Pull Request Checklist

Depends on #4499
Closes #4440

@LecrisUT LecrisUT added this to the 1.66 milestone Jan 16, 2026
@LecrisUT LecrisUT added area | libraries Issues related to beakerlib libraries support status | blocked The merging of PR is blocked on some other issue ci | full test Pull request is ready for the full test execution labels Jan 16, 2026
@github-project-automation github-project-automation bot moved this to backlog in planning Jan 16, 2026
@LecrisUT LecrisUT moved this from backlog to review in planning Jan 16, 2026
@LecrisUT LecrisUT mentioned this pull request Jan 22, 2026
1 task
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
@LecrisUT LecrisUT changed the title Allow beakerlib libraries with clashing repo (and name) parts Allow beakerlib libraries with clashing repo or name parts Jan 26, 2026
Signed-off-by: Cristian Le <git@lecris.dev>
@LecrisUT LecrisUT changed the title Allow beakerlib libraries with clashing repo or name parts Allow beakerlib libraries with partially clashing repo and name Jan 26, 2026
@LecrisUT LecrisUT removed the status | blocked The merging of PR is blocked on some other issue label Jan 26, 2026
@psss
Copy link
Contributor

psss commented Jan 26, 2026

Seems there are some failing tests:

Library 'openssl/certgen (https://github.com/beakerlib/openssl)' conflicts with previously fetched 'openssl/certgen (https://github.com/beakerlib/openssl#master)'.
:: [ 13:55:37 ] :: [   FAIL   ] :: Command 'tmt run -arvvvddd plan --name 'rpm|fmf|nick|duplicate'' (Expected 0, got 2)

@LecrisUT
Copy link
Contributor Author

Seems there are some failing tests:

Library 'openssl/certgen (https://github.com/beakerlib/openssl)' conflicts with previously fetched 'openssl/certgen (https://github.com/beakerlib/openssl#master)'.
:: [ 13:55:37 ] :: [   FAIL   ] :: Command 'tmt run -arvvvddd plan --name 'rpm|fmf|nick|duplicate'' (Expected 0, got 2)

Let's postpone this one. The test failures are related to the feature that I was planning to address later one, but it seems I cannot fix the tests without that feature.

  • Allow for whole libraries to collide and take the first definition Postponed

  • Adjust the order of library fetching to account for the relaxed condition above Postponed

@LecrisUT LecrisUT moved this from review to implement in planning Jan 27, 2026
@LecrisUT LecrisUT self-assigned this Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area | libraries Issues related to beakerlib libraries support ci | full test Pull request is ready for the full test execution

Projects

Status: implement

Development

Successfully merging this pull request may close these issues.

Library conflicts with different url

2 participants