-
Notifications
You must be signed in to change notification settings - Fork 162
Allow beakerlib libraries with partially clashing repo and name #4503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LecrisUT
wants to merge
7
commits into
teemtee:main
Choose a base branch
from
LecrisUT:fix/4440
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+112
−157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Contributor
|
Seems there are some failing tests: |
Contributor
Author
Let's postpone this one. The test failures are related to the feature that I was planning to address later one, but it seems I cannot fix the tests without that feature.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area | libraries
Issues related to beakerlib libraries support
ci | full test
Pull request is ready for the full test execution
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code should already have allowed for libraries with different
namepart but same repo, but as shown in practice that did not happen. This is because the string construction in ofstr(Beakerlib)only took the last part of thename, disallowing/foo/common,/bar/common. But beakerlib does not seem to actually have that restriction afaict.Summary of changes:
Allow for whole libraries to collide and take the first definitionPostponedAdjust the order of library fetching to account for the relaxed condition abovePostponednon-existing-urlhandling to thegit_cloneutility(repo)/(name)as it would be used inrlImportPull Request Checklist
extend the test coveragePostponed, only example right now of the failure in Library conflicts with different url #4440 is in kernel repo which is too slow to use, need to create one in tests repo (Add a beakerlib test case for tmt#4440 tests#23)Depends on #4499
Closes #4440