Skip to content

Fix serviceaccount#60

Closed
drama17 wants to merge 1 commit intomainfrom
sa-fix
Closed

Fix serviceaccount#60
drama17 wants to merge 1 commit intomainfrom
sa-fix

Conversation

@drama17
Copy link
Contributor

@drama17 drama17 commented Sep 25, 2025

image image

@github-actions
Copy link

❌ Helm Chart Tests Failed

Some charts failed validation:

Chart Version Check Template Validation Dry-run Installation Overall Status
common ❌ Not incremented ✅ Passed ✅ Passed ❌ Failed

Summary:

  • 📊 Charts tested: common
  • ❌ Failed charts: common
  • ✅ Successful charts: ****

🔍 Debugging Information:

Please fix the issues before merging. 🔧

@github-actions
Copy link

❌ Helm Chart Tests Failed

Some charts failed validation:

Chart Version Check Template Validation Dry-run Installation Overall Status
common ❌ Not incremented ✅ Passed ✅ Passed ❌ Failed

Summary:

  • 📊 Charts tested: common
  • ❌ Failed charts: common
  • ✅ Successful charts: ****

🔍 Debugging Information:

Please fix the issues before merging. 🔧

@github-actions
Copy link

🎉 Helm Chart Tests Passed!

All modified charts have been successfully validated:

Chart Version Check Template Validation Dry-run Installation Overall Status
common ✅ Incremented ✅ Passed ✅ Passed ✅ Passed

Summary:

  • ✅ Charts tested: common
  • ✅ All template validations passed
  • ✅ All dry-run installations passed

📋 Detailed Information:

The PR is ready for review! 🚀

Note: Charts will be automatically released when this PR is merged to main.

@drama17 drama17 marked this pull request as ready for review September 25, 2025 19:16
@drama17 drama17 requested a review from a team September 25, 2025 19:17
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- if .Values.serviceAccount.create }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it OK to always create the SA?

@drama17 drama17 closed this Jan 27, 2026
@drama17 drama17 deleted the sa-fix branch February 24, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants