Componentization of the Launcher #116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to Mouse and see if I can just use it
kevinfrei
commented
Jan 28, 2026
| // now | ||
| public static double MotorResistance = 9.2 / 12; | ||
|
|
||
| // TODO: Make this more configurable. Maybe just turn it into a little helper function that |
Member
Author
There was a problem hiding this comment.
This "REGRESSION_*" stuff should be changed to be a function in the Config class, instead of all these constants.
| return Command.create(self::setRegressionTeleop); | ||
| } | ||
|
|
||
| public static Command IncreaseRegressionDTeleop() { |
Member
Author
There was a problem hiding this comment.
This ones feels like a hack for something misbehaving. Let's see if we can fix the misbehavior.
kevinfrei
commented
Jan 28, 2026
Member
Author
kevinfrei
left a comment
kevinfrei
left a comment
There was a problem hiding this comment.
Try to move the validator opmode into the component.
|
|
||
| @Configurable | ||
| @SuppressWarnings("unused") | ||
| @TeleOp(name = "Launcher Cfg") |
Member
Author
There was a problem hiding this comment.
Sure would be cool if this were available as part of the component (I should try it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a look at my changes; Please provide feedback!