-
-
Notifications
You must be signed in to change notification settings - Fork 33
State improvements #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
techniq
wants to merge
76
commits into
docs-v2
Choose a base branch
from
state-refactor
base: docs-v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
State improvements #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… across components
🦋 Changeset detectedLatest commit: 2a6d483 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
commit: |
Merged
… `tooltip` (boolean), simplifying use case
…describe purpose and fix conflict with new `tooltip` snippet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
tooltipState.dataandtooltipState.payloadseriesproporientationtoChart(if needed)?seriesStateoncontextChartStategeoContext/brushContext/tooltipContexttogeoState/ etc<GeoContext bind:geoContext>to<GeoContext bind:state>(and BrushContext, TooltipContext, TransformContext)GeoStateetc withinChart/ChartState?ReplacegetGeoContextwithgetChartContextand usectx.geogetGeoContextfor overrides such as a translucent globeGeoContext/ etc? (if it doesn't have any pointer events / elements)Chart. Simplified and renamedGeoContexttoGeoProjection$effect()logic inGeoContexttoGeoState<BarChart seriesLayout="group">regression (before this PR)createLegendProps()and handle directly sincectx.seriesStateis availableChartAnnotationsto usectx.seriesStateDefaultTooltipto usectx.seriesStateTransformStatehandle pointer eventsonPointerMove, etc or withinTransformContexttooltipContextprops (Arc, GeoPath, etc) totooltipState(or justtooltip)?tooltipMetaContext(consolidate payload, etc)related:
SeriesStatefor simplified charts #487