Conversation
Co-authored-by: Logan Ramos <lramos15@gmail.com>
* Restructured Index.html and added endpoint for herald to push dispatch info to * Styled Dispatch alerts, set dispatch alert duration to three minutes, and fixed odds and ends
* Changed Styling to capitalize dispatch info by request of RPIA dev-team coordinator * Capitalize the start of words and Uppercase the determinant in Dispatch Alerts * Moved Dispatch style to style-dispatch.scss
…h other (#68) * Changed Styling to capitalize dispatch info by request of RPIA dev-team coordinator * Capitalize the start of words and Uppercase the determinant in Dispatch Alerts * Moved Dispatch style to style-dispatch.scss * Fixed issues with dispatches that occur within 3 minutes of each other * Correct Logic Errors in ClearDispatch Timeout * Added authentication token for herald dispatch
ddbruce
commented
Mar 15, 2023
Comment on lines
+3
to
+4
| const longitude = -73.67577; | ||
| const latitude = 42.72927; |
Member
Author
There was a problem hiding this comment.
These should get pulled out into environment variables
Contributor
There was a problem hiding this comment.
How would one do this on the client side?
Member
Author
There was a problem hiding this comment.
Ermmm you wouldn't. My mistake. This should probably be pulled from the server via API which will have it stored in an env var. Alternately, we could use the HTML Geo API, but this is probably less desirable.
Member
Author
|
@CKegel see the above. I can't explicitly request feedback because I created the PR. |
* Spell checking and code adjustments * Added token authentication to admin POST endpoints * restructure admin authentication
lramos15
previously approved these changes
Mar 20, 2023
Member
Author
|
Approved with only a housekeeping |
Member
Author
|
Thanks to @CKegel for putting in basically all of the legwork for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.