Conversation
Contributor
|
Can you fix the JavaScript file to use ES6 notation such as let instead of var. Also you can remove the dependency on jQuery as current JavaScript standards make it pretty much obsolete. I also request that you fix the code climate issue above. Code climate is our automatic structure checker which ensures that the code is maintainable. Lastly, you need to bump the version in package.json |
zapdos26
suggested changes
Mar 3, 2020
public/js/weather.js
Outdated
| @@ -0,0 +1,70 @@ | |||
| // Set API key, longitude, and latitude | |||
| const api = "232f1a91a4893327ac3317c3786ac2be"; | |||
Contributor
There was a problem hiding this comment.
Please remove the hardcoded API key from the file and instead add it to the environment variable.
|
Code Climate has analyzed commit 5e5b2b0 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Member
|
@ymmahmoud bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a weather column to fill some of the whitespace between the rider names/900s and the call volume blocks. This weather column pulls data from the openweathermap API and automatically updates icon colors based on light mode vs. dark mode. It currently shows 4 days of weather because any more would cause notes and chores to be pushed down.