Adding support for PHP 7.4 typed properties#52
Draft
mattjanssen wants to merge 1 commit intotebru:masterfrom
Draft
Adding support for PHP 7.4 typed properties#52mattjanssen wants to merge 1 commit intotebru:masterfrom
mattjanssen wants to merge 1 commit intotebru:masterfrom
Conversation
mattjanssen
force-pushed
the
feature/php-7.4-typed-properties
branch
4 times, most recently
from
495866c to
d4b570b
Compare
mattjanssen
force-pushed
the
feature/php-7.4-typed-properties
branch
from
d4b570b to
38dd2a1
Compare
| } | ||
| } | ||
|
|
||
| if ($property !== null && $property->getType() !== null) { |
Member
There was a problem hiding this comment.
You can check to see if $property has the method getType() and support back to 7.1
| * @var string | ||
| */ | ||
| private $city; | ||
| private string $city; |
Member
There was a problem hiding this comment.
I'd make new mocks for 7.4 that we can combine later
Member
|
I'd like to wait for a major version change until php 8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51
❗ Breaking Change: Requires PHP 7.4 (can this be avoided?)
This adds checking of the reflection property type just after checking getter and setter types.