Give users the option to hide the "X" close button with argument show_close_button#21
Open
PetervanLunteren wants to merge 7 commits intoteamtv:mainfrom
Open
Give users the option to hide the "X" close button with argument show_close_button#21PetervanLunteren wants to merge 7 commits intoteamtv:mainfrom
show_close_button#21PetervanLunteren wants to merge 7 commits intoteamtv:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this! Its almost exactly what I need.
This PR added a
show_close_buttonparameter to theModalclass to allow toggling the visibility of the close ("X") button. The button now only renders ifshow_close_button=True(default behaviour). This gives developers more control over modal closing behavior. In my use case, I want to disable the "X" button so users can only close the modal via a custom button with additional explanation.