Precheck chatbot.start integration #2687
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd rolled back done changes to allow this chore(nginx): simulate CloudFront + ALB edge/gateway setup deleted: sse streaming endpoint for chatbot and corresponding logic
…x rerouting with query token in nginx files
note: started on passing through x-request-id to frontend, however this needs to be explored in future if necessary
feat: added check for errors, so errors are returned in application/problem+json if not already in this format feat: added path for generating jwt token for sse stream + function to generate it
…-backend into precheck-chatbot.start-integration
…docstrings add: tests for PrecheckHttpResponse.php
…dy is clearer: deleted unclear json(), but do asJson() directly in method.
…-backend into precheck-chatbot.start-integration
…nd rolled back done changes to allow this chore(nginx): simulate CloudFront + ALB edge/gateway setup deleted: sse streaming endpoint for chatbot and corresponding logic
…x rerouting with query token in nginx files
note: started on passing through x-request-id to frontend, however this needs to be explored in future if necessary
feat: added check for errors, so errors are returned in application/problem+json if not already in this format feat: added path for generating jwt token for sse stream + function to generate it
…nd rolled back done changes to allow this chore(nginx): simulate CloudFront + ALB edge/gateway setup deleted: sse streaming endpoint for chatbot and corresponding logic
…x rerouting with query token in nginx files
note: started on passing through x-request-id to frontend, however this needs to be explored in future if necessary
feat: added check for errors, so errors are returned in application/problem+json if not already in this format feat: added path for generating jwt token for sse stream + function to generate it
…docstrings add: tests for PrecheckHttpResponse.php
…dy is clearer: deleted unclear json(), but do asJson() directly in method.
…nd rolled back done changes to allow this chore(nginx): simulate CloudFront + ALB edge/gateway setup deleted: sse streaming endpoint for chatbot and corresponding logic
note: started on passing through x-request-id to frontend, however this needs to be explored in future if necessary
…dy is clearer: deleted unclear json(), but do asJson() directly in method.
…on' into precheck-chatbot.start-integration # Conflicts: # app/Support/Microservices/Precheck/PrecheckMicroClient.php # docker/alb/nginx.conf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Started on connecting microservice chatbot with the system.
This PR is for in between code review, some open todo's for further development: