Skip to content

Conversation

@chomki32
Copy link
Contributor

@chomki32 chomki32 commented Nov 4, 2024

๐Ÿ“ PR ์œ ํ˜•

  • ๐Ÿš€ feature ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๐Ÿž ๋ฒ„๊ทธ ๋ฐœ์ƒ
  • ๐Ÿ”จ ๋ฆฌํŒฉํ† ๋ง
  • ๐Ÿ“‹ ๋ฌธ์„œ์ž‘์„ฑ
  • ๐ŸŒ ๋นŒ๋“œ ์„ค์ • ๋ฐ ๋ฌธ์ œ
  • ETC

๐Ÿ“ PR ์„ค๋ช…

๊ตฌ๊ธ€, ์นด์นด์˜ค ๋„ค์ดํ‹ฐ๋ธŒ ๋กœ๊ทธ์ธ ๊ธฐ๋Šฅ ๊ตฌํ˜„

๊ด€๋ จ๋œ ์ด์Šˆ ๋„˜๋ฒ„

โœ… ์ž‘์—… ๋ชฉ๋ก

  • Kakao Login ๊ธฐ๋Šฅ ๊ตฌํ˜„

React ํ˜ธ์ถœ

jsToNative({val1: "loginKakao"}, (data: any) => {
 // ์„œ๋ฒ„ ๋กœ๊ทธ์ธ ์š”์ฒญ
})
  • Google Login

React ํ˜ธ์ถœ ๋ฐฉ๋ฒ•

jsToNative({val1: "loginGoogle"}, (data: any) => {
 // ์„œ๋ฒ„ ๋กœ๊ทธ์ธ ์š”์ฒญ
})
  • ์‘๋‹ต JSON
{
  result: "success" | "error" | "failed", // failed๋Š” ๋กœ๊ทธ์ธ ์‹คํŒจ์˜ ๊ฒฝ์šฐ
  token: string, // ๋กœ๊ทธ์ธ ํ† ํฐ
  msg: string // ์—๋Ÿฌ๋ฉ”์‹œ์ง€
}

MRํ•˜๊ธฐ ์ „์— ํ™•์ธํ•ด์ฃผ์„ธ์š”

  • local code lint ๊ฒ€์‚ฌ๋ฅผ ์ง„ํ–‰ํ•˜์…จ๋‚˜์š”?
  • loca ci test๋ฅผ ์ง„ํ–‰ํ•˜์…จ๋‚˜์š”?

๐Ÿ“š ๋…ผ์˜์‚ฌํ•ญ

๐Ÿ“š ETC

@seungdeok
Copy link
Member

@chomki32
apple๋กœ๊ทธ์ธ์€ ์ด๋ฒˆ PR์—์„œ ์ œ์™ธ๋˜๋Š”๊ฒŒ ๋งž์œผ์‹ค๊นŒ์š”?

@seungdeok
Copy link
Member

@chomki32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants