Skip to content

fix the under-constrained problems #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Koukyosyumei wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix the under-constrained problems #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions circuits/average/circuit.circom
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@ template Average(n) {
}

denominator_inv <-- invert(n);

component eq = IsEqual();
eq.in[0] <== 1;
eq.in[1] <== denominator_inv * n;
denominator_inv * n === 1;

out <== sum * denominator_inv;

Expand Down
5 changes: 4 additions & 1 deletion circuits/none-zero/circuit.circom
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,13 @@ pragma circom 2.0.3;
template IsNoneZero() {
signal input in;
signal output out;

signal inv;

inv <-- (in != 0) ? 1/in : 0;
inv <-- in!=0 ? 1/in : 0;

out <== in*inv;
in*(-out+1) === 0;
}

component main = IsNoneZero();
10 changes: 5 additions & 5 deletions circuits/none-zero/circuit1.circom
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ include "../../node_modules/circomlib/circuits/comparators.circom";
template IsNoneZero() {
signal input in;
signal output out;
signal inv;

component iszero = IsZero();
iszero.in <== in;
inv <-- (iszero.out != 0) ? 0 : 1;
component iszero_1 = IsZero();
iszero_1.in <== in;
component iszero_2 = IsZero();
iszero_2.in <== iszero_1.out;

out <== inv;
out <== iszero_2.out;
}

component main = IsNoneZero();