missing calls of reset functions in ListMultibucket and Multivocab#8
Open
gilmoright wants to merge 1 commit intotdozat:masterfrom
Open
missing calls of reset functions in ListMultibucket and Multivocab#8gilmoright wants to merge 1 commit intotdozat:masterfrom
gilmoright wants to merge 1 commit intotdozat:masterfrom
Conversation
reset() for each vocab object in it. Added calls of reset() function for every bucket in ListMultibucket class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added override of reset() function in Multivocab class, now it calls the reset() for each vocab object in it.
Added calls of reset() function for every bucket in ListMultibucket class
When I was doing some experiments with parsing one sentence at a time, I noticed that one of multivocabs was saving data even after I called the reset() function. There are 2 little fixes, in case someone will try to do something simmilar.