Fixed all non-passing tests in call_spec#46
Open
mvastola wants to merge 1 commit intotcocca:masterfrom
Open
Conversation
The only non-passing tests remaining (though there are admittedly a lot, I think they're all related) are in wrapper_spec.rb.
Owner
|
Looks like travis still has failures: https://travis-ci.org/tcocca/active_pdftk/builds/41992879 |
Author
|
Yup, but those are in ./spec/active_pdftk/wrapper_spec.rb, which I said in the comment aren't fixed yet. It does have less errors though than it does without this commit. Thus the "partially fixes" and not "fully fixes". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only non-passing tests remaining (though there are admittedly a lot, I think they're all related) are in wrapper_spec.rb.
Partially fixes issue #36. For real this time.