Fix Java 21 compatibility issues by replacing getFirst() with get(0)#348
Closed
Copilot wants to merge 3 commits intocodex/create-expiration-event-class-and-methodsfrom
Closed
Conversation
…radle.properties, and pom.xml
# Conflicts: # buildSrc/build.gradle # gradle.properties # nostr-java-api/pom.xml # nostr-java-base/pom.xml # nostr-java-client/pom.xml # nostr-java-crypto/pom.xml # nostr-java-encryption/pom.xml # nostr-java-event/pom.xml # nostr-java-examples/pom.xml # nostr-java-id/pom.xml # nostr-java-util/pom.xml # pom.xml
tcheeric
changed the base branch from
main
to
codex/create-expiration-event-class-and-methods
Copilot
AI
changed the title
[WIP] Revert commit e835e3700e7772eeec83d1db9d4ffe1ec52745cf due to compilation error
Fix Java 21 compatibility issues by replacing getFirst() with get(0)
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The codebase was using Java 21's
List.getFirst()method in multiple locations, causing compilation failures when building with Java 17. This created a barrier for developers and CI systems that haven't upgraded to Java 21 yet.Changes
Replaced all instances of
List.getFirst()with the Java 17 compatibleList.get(0)method across 8 files:Main Source Files
nostr-java-event/src/main/java/nostr/event/filter/Filters.java- Filter validation logicnostr-java-event/src/main/java/nostr/event/impl/MerchantEvent.java- Merchant event attribute accessnostr-java-event/src/main/java/nostr/event/json/codec/FiltersEncoder.java- JSON encoding logicTest Files
nostr-java-event/src/test/java/nostr/event/unit/PriceTagTest.java- Price tag comparison testsnostr-java-event/src/test/java/nostr/event/unit/RelaysTagTest.java- Relay tag deserialization testsnostr-java-api/src/test/java/nostr/api/unit/JsonParseTest.java- JSON parsing unit testsnostr-java-api/src/test/java/nostr/api/integration/ApiNIP99RequestIT.java- Integration testsnostr-java-id/src/test/java/nostr/id/EventTest.java- Event ID testsTesting
mvn verifycompletes successfullyImpact
This change maintains backward compatibility while ensuring the project can be built and tested with Java 17, removing the hard dependency on Java 21 for basic compilation.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
httpIf you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.