Open
Conversation
Owner
|
Thanks for the PR! I will test it soon and merge it if no problem occurs. |
Owner
|
@mathieudutour I am seeing different behavior than I have imagined so need to clarify a few things. Are your changes meant to keep all nodes in the same place if they existed before? Did you test it with changing a file's title? If yes to both, then it doesn't work for me 😞 . If no – I might be hitting some edge case. Let me know which one is the case here 😄 . |
Author
|
So they keep the same place when you add a file or change its title. It doesn’t when you close the window and reopen it |
Author
|
I mean they don’t keep the exact same position, it just restarts the simulation with the previous position (so they can still spread, etc.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change keeps the position of the nodes if we already have them instead of reseting them.
If we'd want to keep the same positions even closing/reopening the window, we can store the
nodeDatasomewhere and pull it back later