[explicit-resource-management] Add remaining tests specific to using in for-of and for-await-of syntax #4484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@syg do I recall correctly that you found a bug in one of the |
Contributor
|
Sorry, I don't remember either. |
ptomato
requested changes
May 17, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Thanks! Just needs the es6id entries replaced with esid section names.
I also had one question about head-{await-,}using-bound-names-fordecl-tdz.js, but that is probably due to me not understanding what exactly is happening in the spec.
test/language/statements/for-of/head-await-using-bound-names-fordecl-tdz.js
Outdated
Show resolved
Hide resolved
test/language/statements/for-of/head-await-using-bound-names-fordecl-tdz.js
Show resolved
Hide resolved
ptomato
approved these changes
May 21, 2025
ptomato
force-pushed
the
explicit-resource-management-for-of
branch
from
c2852d6 to
f17461b
Compare
Contributor
Author
Ah, I found it. This is the test that is incorrect: test/language/statements/using/syntax/using-invalid-for-using-of-of.js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to make review more manageable, this extracts the remaining tests specific to
using/await usinginfor-ofandfor-await-ofstatements from #3866