[explicit-resource-management] Add remaining tests specific to using statement syntax #4483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
reviewed
May 20, 2025
test/language/statements/using/syntax/using-invalid-for-using-of-of.js
Outdated
Show resolved
Hide resolved
ptomato
reviewed
May 29, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Since I just reviewed the await using PR, this went fairly quickly. Please apply all the comments there to this PR as well.
rbuckton
force-pushed
the
explicit-resource-management-using-syntax
branch
from
d1528c9 to
f56e3f7
Compare
ptomato
reviewed
Jun 24, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Just one question to resolve, otherwise merge ready.
test/language/statements/using/syntax/using-invalid-assignment-next-expression-for.js
Outdated
Show resolved
Hide resolved
test/language/statements/using/syntax/using-invalid-assignment-statement-body-for-of.js
Outdated
Show resolved
Hide resolved
rbuckton
force-pushed
the
explicit-resource-management-using-syntax
branch
from
a1bffe6 to
7f71843
Compare
ptomato
force-pushed
the
explicit-resource-management-using-syntax
branch
from
28ad4b5 to
e2e1751
Compare
ptomato
approved these changes
Nov 4, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
I'm assuming the ReferenceError was the only thing that changed, I reviewed the rest a while ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to make review more manageable, this extracts the remaining tests specific to
usingstatement syntax from #3866