[explicit-resource-management] Add remaining tests specific to await using statement semantics
#4480
+3,583
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuckton
changed the title
await using statement semantics
arai-a
reviewed
Nov 11, 2025
Contributor
arai-a
left a comment
arai-a
left a comment
There was a problem hiding this comment.
tested on SpiderMonkey, and 4 tests fail
...nguage/statements/await-using/initializer-Symbol.dispose-called-at-end-of-switchstatement.js
Outdated
Show resolved
Hide resolved
...e/statements/await-using/initializer-Symbol.asyncDispose-called-at-end-of-switchstatement.js
Outdated
Show resolved
Hide resolved
...language/statements/await-using/global-use-before-initialization-in-declaration-statement.js
Outdated
Show resolved
Hide resolved
test/language/statements/await-using/global-use-before-initialization-in-prior-statement.js
Outdated
Show resolved
Hide resolved
rbuckton
force-pushed
the
explicit-resource-management-await-using
branch
from
d2b28bc to
664a84c
Compare
Contributor
Author
|
Thanks @arai-a, should be fixed now. |
Contributor
|
Since this has been reviewed by someone involved in the implementation, I would be comfortable to merge it now, to avoid holding it up any further. I personally won't have the bandwidth to get around to it in the near future. @gibson042 @ljharb @Ms2ger What do you think? |
ptomato
approved these changes
Jan 22, 2026
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
proxying arai-a's review
ptomato
force-pushed
the
explicit-resource-management-await-using
branch
from
557f298 to
5d94a30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to make review more manageable, this extracts the remaining tests specific to
await usingsemantics from #3866