Add tests for symbols added in Explicit Resource Management #4391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
approved these changes
Feb 11, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Other than the esid: pending, looks good. Thanks!
| // Copyright (C) 2016 the V8 project authors. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
| /*--- | ||
| esid: pending |
Contributor
There was a problem hiding this comment.
We should not add new tests with esid: pending. I guess the relevant sections haven't been added to the spec yet (tc39/proposal-explicit-resource-management#185), but let's just assume they'll be called sec-symbol.asyncdispose and sec-symbol.dispose.
Author
There was a problem hiding this comment.
Understood i guess the sections are there now, lemme check!
Member
|
Can we also add some tests that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This pr just adds the simple symbol tests from #3866
Thank you!