Add tests for SuppressedError #4390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
force-pushed
the
explicit-resource-management-suppressed-error
branch
from
b5c9e71 to
6214039
Compare
ljharb
reviewed
Feb 26, 2025
| const e = new SuppressedError(error, suppressed, message); | ||
|
|
||
| assert.sameValue(messageStringified, true); | ||
| const keys = Object.getOwnPropertyNames(e); |
Member
There was a problem hiding this comment.
i think this might not work as expected due to the own stack property in v8?
ljharb
added a commit
to es-shims/SuppressedError
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This pr adds the test of SuppressedError from #3866
Thank you!