[explicit-resource-management] some boilerplate tests from PR #3866 #4172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ms2ger
approved these changes
Jul 29, 2024
test/built-ins/AsyncDisposableStack/prototype/disposed/length.js
Outdated
Show resolved
Hide resolved
to make reviewing easier.
ioannad
commented
Jul 29, 2024
- Fixes to two tests testing Map.prototype.size - Description fixes
ioannad
force-pushed
the
ERM-some-boilerplate-in-PR3866
branch
from
41720df to
13cc9e0
Compare
ptomato
approved these changes
Jul 29, 2024
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Let's get the ESMeta job green and then merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits some of the boilerplate tests from PR #3866 to make reviewing all those files a little easier.
Includes the boilerplate tests mentioned in this comment except brand checks for functions and tests for object prototypes and extensibility.
In particular this PR adds the following tests from #3866 (links from the comment above):
verifyProperty()instead)Each of these bullet points is a separate commit.
cc. @rbuckton