Conversation
Using import.hx so that all the functions are imported together.
Trying to make minimal changes to the test cases, except for `testSparseArray2OrderedKeysIterate`, which printed 10,000 characters.
`testArray2InterfaceCast()`. Just to be sure DCE won't mess it up.
Except for one that fit better in TestCommonOperations.hx.
Plus, fix a bug where `multiply()` transposes the resulting matrix. (Maybe due to confusion over whether it was row-major or column-major.)
tbrosman
reviewed
Sep 23, 2022
player-03
commented
May 30, 2024
| "tasks": [ | ||
| { | ||
| "label": "hxmath: test in C++", | ||
| "command": "haxe test_cpp.hxml --cmd ./bin/cpp", |
Contributor
Author
There was a problem hiding this comment.
Whoops, this won't work on Windows. Maybe I should just not include tasks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I switched to utest, moved tests around so that related tests would go in the same file, rewrote several tests, and added several missing tests. Not all the missing tests, but at least now it'll be easier to spot when a test is missing.
I did use some more advanced Haxe features, such as import.hx (which could easily be reverted) and two macros (which could not). I realize macros can be hard to understand, so I did my best to document them clearly. The macros are required to write shorter and clearer test cases while still getting detailed error messages. If a randomized test fails, it needs to be able to print the values that caused the issue, or you may never be able to reproduce that situation.
This addresses most of #18, but might not be enough to close it.