Hydrate check if _id are strings or not#136
Open
streetlib wants to merge 189 commits intotaterbase:masterfrom
Open
Hydrate check if _id are strings or not#136streetlib wants to merge 189 commits intotaterbase:masterfrom
streetlib wants to merge 189 commits intotaterbase:masterfrom
Conversation
More dynamic version info
Prior, only geo_point were kept in the mapping.
In my tests, the mapping format returned by the getMapping function is not the same between 0.90.11 and 1.0
Enveloppe corners were in wrong order resulting in a bad test.
Provided fix for etting first level `hits` field of search results when used hydrate
…hydrate-hits Cubuzoa/feature/hydrate hits
Nlko geo shape
remove river code
…ulk-and-array-indexing Albanm/feature/bulk and array indexing
added fuzzy search test
…pdate-empty fix(postSave): fix findOneAndUpdate if document doesn't exist
added support for suggesters
removed gulp dependency. moved to ESLint instead of jshint/jscs
added AUTHORS file
…eralls updated yml config for travisci and coveralls
Recognizes an es_type of nested with es_fields and maps it
Check if they are strings or ObjectIds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found there could be a problem if you don't index the MongoDB
_idfield and you try to usehydrateoption.Basically the problem is the
_idcomes as string if you doesn't index it and so this queryquery = model.find({_id: {$in: ids}})fails (cannot find any document).To reproduce the issue, you have to change your MongoDB schema with
_id: { es_indexed: false }, then you should synchronize and finally try to do a query withhydrateoption settrue.You should see the hits only with the
hydrateset tofalse.