-
Notifications
You must be signed in to change notification settings - Fork 0
Livraison de la version fonctionnelle + documentation des pistes d’amélioration #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tassadit-sadoun
wants to merge
35
commits into
master
Choose a base branch
from
develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and env vars, mount shared_data volume - Define container name for easier identification - Modify exposed port for better compatibility - Add .env file support and environment variables injection - Mount shared_data directory as volume for persistent shared storage
- switch to slim base image for reduced image size - copy requirements.txt first to leverage Docker layer caching - add pip upgrade and --no-cache-dir to minimize image footprint - define default CMD to run Celery worker with info log level
- Add core dependencies: fastapi, celery, pandas, psycopg[binary], redis, requests, SQLAlchemy, uvicorn, pydantic[email] - Include testing tools: pytest, pytest-cov, coverage, httpx - Add additional libraries: importlib-metadata, python-multipart, starlette
- Token creation and verification logic - Loaded simulated credentials and secret key from environment variables
…ct structure to README
- Included detailed pytest summary showing all 15 tests passed - Tests cover API routes and asynchronous import task handling - Confirms robustness of client import, pagination, and error cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR contient :
La version fonctionnelle de l’API conformément au périmètre initial.
Un fichier IMPROVEMENTS.md recensant les améliorations potentielles identifiées (tests, sécurité, validations, performances, etc.).
Une mise à jour du README.md incluant un lien vers ces pistes.
Faute de temps, certaines améliorations n’ont pas été implémentées mais sont documentées pour faciliter leur ajout ultérieur.