fix: Fix a bug where time sheet checks would fail #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes an issue where time sheet check would report a too high reporting requirement in time sheets when resource was booked outside of working hours in the reporting interval. If a resource has working hours from 8-12 mon-tue but was booked 8-16 Monday and did not work Tuesday, the time sheet checker would report that the resource must report 12 hours of work in the time sheet for that week. One would expect that 8 hours is enough, as the assigned working hours is 8 hours. With this change, if the time sheet checker will accept that the resource worked 4 hours outside normal working hours on Monday, and will not require the resource to work 4 additional hours in normal working hours on Tuesday.
If time sheet does not match bookings, an error is generated. This causes problems when working with multiple scenarios, because the check is run for all scenarios, not just the tracking scenario. This patch reduces the error to a warning in order to allow execution to continue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue where time sheet check would report a too high
reporting requirement in time sheets when resource was booked outside of working
hours in the reporting interval.
If a resource has working hours from 8-12 mon-tue but was booked 8-16 Monday and
did not work Tuesday, the time sheet checker would report that the resource must
report 12 hours of work in the time sheet for that week. One would expect that 8
hours is enough, as the assigned working hours is 8 hours.
With this change, if the time sheet checker will accept that the resource worked
4 hours outside normal working hours on Monday, and will not require the
resource to work 4 additional hours in normal working hours on Tuesday.