Fixed an exception that occurs when parse_message_line receives empty string#23
Open
nitzanfarhi wants to merge 1 commit intotarmstrong:masterfrom
Open
Fixed an exception that occurs when parse_message_line receives empty string#23nitzanfarhi wants to merge 1 commit intotarmstrong:masterfrom
nitzanfarhi wants to merge 1 commit intotarmstrong:masterfrom
Conversation
Author
|
I will also add that this occurs in general when chars like \u2028 exist since they are considered as line breaks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 😄 ,
an exception occured to me when
parse_message_linereceives an empty string.When this occurs,
parse_message_linereturns None.After that,
"\n".jointhrows an exception when one of the members of the list is none.Example to an input that causes this is:
The fix is simple, replace None with empty string.