Skip to content

Conversation

@tarappo
Copy link
Owner

@tarappo tarappo commented Apr 19, 2025

TODO

  • UIテストの削除
  • すべてのテストを実行するのを中止(古いのは実行しない)

@tarappo tarappo requested a review from Copilot April 19, 2025 23:01
@tarappo tarappo self-assigned this Apr 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes outdated UI tests and updates the merge workflow to stop running them.

  • Removed two UI test files.
  • Updated the merge workflow to execute "main_tests" instead of "all_tests".

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
Samples/Xcode16.0/xcode16UITests/xcode16UITestsLaunchTests.swift Removed UI test launch tests
Samples/Xcode16.0/xcode16UITests/xcode16UITests.swift Removed UI test cases
.github/workflows/merge.yml Replaced "bundle exec fastlane all_tests" with "bundle exec fastlane main_tests" to adjust tests run
Files not reviewed (1)
  • Samples/Xcode16.0/xcode16.xcodeproj/project.pbxproj: Language not supported
Comments suppressed due to low confidence (1)

.github/workflows/merge.yml:32

  • Verify that 'main_tests' includes the intended test suite coverage since the previous 'all_tests' command executed more tests, including the now removed UI tests.
bundle exec fastlane main_tests

@tarappo tarappo merged commit acc2c28 into main Apr 19, 2025
3 checks passed
@tarappo tarappo deleted the update_xcode16 branch April 19, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants