Fix scroll sync to work in both directions#122
Open
jackcase04 wants to merge 1 commit intotanabe:mainfrom
Open
Fix scroll sync to work in both directions#122jackcase04 wants to merge 1 commit intotanabe:mainfrom
jackcase04 wants to merge 1 commit intotanabe:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that when the sync scroll button is toggled, scrolling on the editor side would scroll the preview side, but scrolling on the preview side would not scroll the editor side to match it. So this pull request is a fix for that bug.
I added an preview event listener for when the preview side is scrolled, and a isScrolling flag to ensure each side does not try to scroll each other. Lastly, I bypassed the smooth scrolling on the preview side to match the way that the editor side scrolls with a mouse.
The end result is that now you can scroll on either the left or right side of the screen with Sync Scroll enabled and it will sync properly.
Hopefully this is helpful.