Generate Phx using the correct Phoenix 1.3 folder structure#103
Open
fcapovilla wants to merge 4 commits intotalonframework:masterfrom
Open
Generate Phx using the correct Phoenix 1.3 folder structure#103fcapovilla wants to merge 4 commits intotalonframework:masterfrom
fcapovilla wants to merge 4 commits intotalonframework:masterfrom
Conversation
1.3 namespace names.
working. Binding lists were also reformatted so future modifications are easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Issue #90.
The web_base and controller_namespace were added in order to generate the correct namespaces for the two supported Phoenix folder structures.
With this fix, Talon seems to work with the new Phoenix folder structure, but the "talon" folder is added to the "lib/MY_PROJECT/" folder.
I think it will necessary to move it in it own folder in the "lib" directory as "lib/MY_PROJECT_talon".
Do I need to open another Issue to change the folder location?