Skip to content

fix: vun Bypass on 30 days lock period #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
developerfred wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: vun Bypass on 30 days lock period #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions contracts/talent/TalentVault.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,12 @@ contract TalentVault is ERC4626, Ownable, ReentrancyGuard {
/// @notice Represents user's balance meta data
/// @param depositedAmount The amount of tokens that were deposited, excluding rewards
/// @param lastRewardCalculation The timestamp (seconds since Epoch) of the last rewards calculation
/// @param firstDepositAt The timestamp of the FIRST deposit (prevents micro-deposit reset)
/// @param lastDepositAt The timestamp of the most recent deposit
struct UserBalanceMeta {
uint256 depositedAmount;
uint256 lastRewardCalculation;
uint256 firstDepositAt;
uint256 lastDepositAt;
}

Expand Down Expand Up @@ -242,6 +245,10 @@ contract TalentVault is ERC4626, Ownable, ReentrancyGuard {

balanceMeta.depositedAmount += assets;

if (balanceMeta.firstDepositAt == 0) {
balanceMeta.firstDepositAt = block.timestamp;
}

balanceMeta.lastDepositAt = block.timestamp;

return shares;
Expand Down Expand Up @@ -376,13 +383,18 @@ contract TalentVault is ERC4626, Ownable, ReentrancyGuard {
address owner,
uint256 assets,
uint256 shares
) internal virtual override {
UserBalanceMeta storage receiverUserBalanceMeta = userBalanceMeta[receiver];
) internal virtual override {
UserBalanceMeta storage ownerUserBalanceMeta = userBalanceMeta[owner];

if (receiverUserBalanceMeta.lastDepositAt + lockPeriod > block.timestamp) {
if (ownerUserBalanceMeta.firstDepositAt + lockPeriod > block.timestamp) {
revert CantWithdrawWithinTheLockPeriod();
}

super._withdraw(caller, receiver, owner, assets, shares);

if (balanceOf(owner) == 0) {
ownerUserBalanceMeta.firstDepositAt = 0;
ownerUserBalanceMeta.depositedAmount = 0;
}
}
}
Loading