Skip to content

Implement copy constructor to prevent malloc errors #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamesmulcahy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement copy constructor to prevent malloc errors #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d0ac4a
Implement copy constructor to prevent malloc errors
jamesmulcahy Sep 18, 2014
1db5616
Also clear init() flag in copy constructor
jamesmulcahy Dec 2, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/statsd_client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,17 @@ StatsdClient::StatsdClient(const string& host, int port, const string& ns)
config(host, port, ns);
srandom(time(NULL));
}

StatsdClient::StatsdClient(const StatsdClient &original)
{
// Must create our own storage for ClientData object; don't share original's
d = new _StatsdClientData;
Copy link

@Loki-Astari Loki-Astari Aug 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unsafe. You should not be managing raw pointers in your class.
If you use std::unique_ptr it will solve this problem.
As it stands this class is broken because it does not implement the rule of three/five (ie there is no assignment operator). So you still have potential malloc errors (though I hope there are no mallocs in your code)

*d = *original.d;

// Don't share original's socket, either.
d->init = false;
d->sock = -1;
}

StatsdClient::~StatsdClient()
{
Expand Down
1 change: 1 addition & 0 deletions src/statsd_client.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ struct _StatsdClientData;
class StatsdClient {
public:
StatsdClient(const std::string& host="127.0.0.1", int port=8125, const std::string& ns = "");
StatsdClient(const StatsdClient &original);
~StatsdClient();

public:
Expand Down