fix(docker): Restrict docker port to 127.0.0.1 to prevent public IPv6 exposure#154
Open
mattr64 wants to merge 1 commit intotaigaio:mainfrom
Open
fix(docker): Restrict docker port to 127.0.0.1 to prevent public IPv6 exposure#154mattr64 wants to merge 1 commit intotaigaio:mainfrom
mattr64 wants to merge 1 commit intotaigaio:mainfrom
Conversation
…blic IPv6 exposure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current docker-compose config exposes port 9000 to public IPv6 addresses. Users are likely to place a reverse proxy in front of this anyway, so locking this down to localhost / 127.0.0.1 by default seems like a sensible thing to do, as a best practise would then be to handle all web requests (v4 or v6) via the reverse proxy in a controlled manner.
They can edit the docker-compose to revert if they really want port 9000 serving on their public IPv6 addresses.