Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/composite/test/backend-test/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,15 @@ runs:

- name: Run script
shell: bash
run: bun run .github/scripts/test/run-backend-tests --should-upload-coverage=${{ inputs.UPLOAD_TEST_COV }}
run: bun .github/scripts/test/run-backend-tests
env:
UPLOAD_TEST_COV: ${{ inputs.UPLOAD_TEST_COV }}
Comment on lines +52 to +54
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Keep the original CLI flag for coverage upload while also exporting the environment variable to avoid breaking scripts that still parse --should-upload-coverage. This ensures backward compatibility and preserves current coverage behavior. [possible issue, importance: 6]

Suggested change
run: bun .github/scripts/test/run-backend-tests
env:
UPLOAD_TEST_COV: ${{ inputs.UPLOAD_TEST_COV }}
run: bun .github/scripts/test/run-backend-tests --should-upload-coverage=${{ inputs.UPLOAD_TEST_COV }}
env:
UPLOAD_TEST_COV: ${{ inputs.UPLOAD_TEST_COV }}


- name: Publish Junit Report
uses: mikepenz/action-junit-report@v6
if: success() || failure()
with:
report_paths: "**/target/surefire-reports/TEST-*.xml"
detailed_summary: true
include_time_in_summary: true
fail_on_failure: false
Comment on lines +56 to +63
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Use always() (with expression syntax) so the report publishes even if the job is cancelled, not just on success or failure. This makes reporting more robust across all job outcomes. [general, importance: 4]

Suggested change
- name: Publish Junit Report
uses: mikepenz/action-junit-report@v6
if: success() || failure()
with:
report_paths: "**/target/surefire-reports/TEST-*.xml"
detailed_summary: true
include_time_in_summary: true
fail_on_failure: false
- name: Publish Junit Report
uses: mikepenz/action-junit-report@v6
if: ${{ always() }}
with:
report_paths: "**/target/surefire-reports/TEST-*.xml"
detailed_summary: true
include_time_in_summary: true
fail_on_failure: false

1 change: 1 addition & 0 deletions .github/workflows/ci-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ permissions:
contents: write
issues: write
pull-requests: write
checks: write

concurrency:
group: ci-${{ github.ref }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/deploy-stg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ permissions:
issues: write
pull-requests: write
statuses: write
checks: write

jobs:
getPRHead:
Expand Down